Skip to content

Conversation

nedley
Copy link
Contributor

@nedley nedley commented Aug 13, 2025

Update pom.xml to point at the newest available ICU and CLDR snapshots and fix the one place where the emoji tools were using removed CLDRFile functionality. Also make a first pass at cleaning up proposal data to avoid associating emoji with the original skin tone or gender proposals just because they had skin tone or gender.

@nedley nedley requested a review from markusicu August 13, 2025 23:23
@nedley
Copy link
Contributor Author

nedley commented Aug 13, 2025

Let’s see if the builders catch the remaining CLDRFile issues…

@nedley
Copy link
Contributor Author

nedley commented Aug 13, 2025

Let’s see if the builders catch the remaining CLDRFile issues…

… they did. ☹️

@nedley nedley force-pushed the ned/emoji_17_charts branch 2 times, most recently from efddf45 to a097fe2 Compare August 21, 2025 18:38
@markusicu
Copy link
Member

@echeran created a CLDR snapshot.
@nedley please try to upgrade to 0.0.0-SNAPSHOT-3404124632
@josh-hadley @jowilco @eggrobin FYI

@markusicu
Copy link
Member

FYI: Also, for ICU we are pulling in 78.0.1-SNAPSHOT which got updated on aug14.

@nedley
Copy link
Contributor Author

nedley commented Aug 22, 2025

OK, I give up.

Error:  /home/runner/work/unicodetools/unicodetools/UnicodeJsps/src/test/java/org/unicode/jsptest/TestAll.java:[5,37] package com.ibm.icu.dev.test.TestFmwk does not exist

@macchiati
Copy link
Member

macchiati commented Aug 22, 2025 via email

@nedley nedley force-pushed the ned/emoji_17_charts branch from 586e87f to f317a3e Compare September 2, 2025 19:21
@markusicu
Copy link
Member

If there are still problems, then @srl295 and @mihnita should be able to help.

@srl295
Copy link
Member

srl295 commented Sep 4, 2025

OK, I give up.


Error:  /home/runner/work/unicodetools/unicodetools/UnicodeJsps/src/test/java/org/unicode/jsptest/TestAll.java:[5,37] package com.ibm.icu.dev.test.TestFmwk does not exist

Also this is a copy or duplicate of the tests in the unicodejsp package !

@nedley
Copy link
Contributor Author

nedley commented Sep 4, 2025

I resolved the TestFmwk issue already, at least as far as compiling. The issue is now the failing tests.

@markusicu
Copy link
Member

Now that the trunk is open for 18, it would be great to get the tools up on recent snapshots of CLDR & ICU :-)

@eggrobin
Copy link
Member

Yes, I will take a look at this.

@markusicu
Copy link
Member

CLDR snapshot from aug27: 0.0.0-SNAPSHOT-649eb5da8e

ICU: 78.0.1-SNAPSHOT, latest is today's 78.0.1-20250916.173842-8

@eggrobin
Copy link
Member

The remaining failures seem to have something to do with script metadata.

@eggrobin
Copy link
Member

why is that test looking at Unicode 12.0 properties????

@eggrobin
Copy link
Member

eggrobin commented Sep 18, 2025

I think we should delete TestIdentifierInfo.

It is testing Unicode 12 Identifier_Type assigments against script metadata; and script metadata has changed, so it breaks. But it cannot straightforwardly be updated to the current version of Unicode: it is explicitly checking things that we do not want to be true, e.g., that the Phaistos disk symbols are Identifier_Type=Exclusion (since Unicode 13.0, they are Identifier_Type=Obsolete instead).

As it was pinned at Unicode 12, this test has done nothing useful since 2019-03-05; if we want to bring back some test for Identifier_Type we can do that, but in the meantime it has become a nuisance.

markusicu
markusicu previously approved these changes Sep 18, 2025
@markusicu
Copy link
Member

tests pass!
thanks @eggrobin !
@nedley ready to squash-and-merge?

@nedley
Copy link
Contributor Author

nedley commented Sep 18, 2025

The CLDR snapshot is still one version behind. Do we want to update it once more or declare victory?

@nedley nedley merged commit 5fe4e28 into main Sep 18, 2025
16 checks passed
@nedley nedley deleted the ned/emoji_17_charts branch September 18, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants