-
-
Notifications
You must be signed in to change notification settings - Fork 57
Emoji 17.0 charts #1198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emoji 17.0 charts #1198
Conversation
Let’s see if the builders catch the remaining CLDRFile issues… |
… they did. |
efddf45
to
a097fe2
Compare
@echeran created a CLDR snapshot. |
FYI: Also, for ICU we are pulling in 78.0.1-SNAPSHOT which got updated on aug14. |
OK, I give up.
|
When ICU dropped support for testfwk, cldr made a copy in its code that can
be used. Probably needs a modified import statement.
…On Fri, Aug 22, 2025, 15:03 Ned Holbrook ***@***.***> wrote:
*nedley* left a comment (unicode-org/unicodetools#1198)
<#1198 (comment)>
OK, I give up.
Error: /home/runner/work/unicodetools/unicodetools/UnicodeJsps/src/test/java/org/unicode/jsptest/TestAll.java:[5,37] package com.ibm.icu.dev.test.TestFmwk does not exist
—
Reply to this email directly, view it on GitHub
<#1198 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMG4M6KVDWEKXYYQBV33O6HUZAVCNFSM6AAAAACD3CPQD2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMJVG44TOOJVGY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
586e87f
to
f317a3e
Compare
Also this is a copy or duplicate of the tests in the unicodejsp package ! |
I resolved the |
Now that the trunk is open for 18, it would be great to get the tools up on recent snapshots of CLDR & ICU :-) |
Yes, I will take a look at this. |
CLDR snapshot from aug27: 0.0.0-SNAPSHOT-649eb5da8e ICU: 78.0.1-SNAPSHOT, latest is today's 78.0.1-20250916.173842-8 |
The remaining failures seem to have something to do with script metadata. |
why is that test looking at Unicode 12.0 properties???? |
I think we should delete TestIdentifierInfo. It is testing Unicode 12 Identifier_Type assigments against script metadata; and script metadata has changed, so it breaks. But it cannot straightforwardly be updated to the current version of Unicode: it is explicitly checking things that we do not want to be true, e.g., that the Phaistos disk symbols are Identifier_Type=Exclusion (since Unicode 13.0, they are Identifier_Type=Obsolete instead). As it was pinned at Unicode 12, this test has done nothing useful since 2019-03-05; if we want to bring back some test for Identifier_Type we can do that, but in the meantime it has become a nuisance. |
The CLDR snapshot is still one version behind. Do we want to update it once more or declare victory? |
Update pom.xml to point at the newest available ICU and CLDR snapshots and fix the one place where the emoji tools were using removed CLDRFile functionality. Also make a first pass at cleaning up proposal data to avoid associating emoji with the original skin tone or gender proposals just because they had skin tone or gender.